Fix Create elevator clipping on Sable sublevels - #1446
Open
VictorioMo wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Create elevator player clipping/teleportation on Sable sublevels.
The issue appears to come from ContraptionCollider.savePlayerFromClipping() mixing global player coordinates with sublevel/contraption coordinates. This could cause the player's Y position to be set roughly 100–200 blocks above the elevator.
The fix converts the relevant contraption Y and anti-clipping raytrace coordinates between Sable sublevel space and global space.
Fixes #1304
Related to #673 and #1297
Test video: https://youtu.be/cQeV1smUpY0
I tested the fix after reloading the world and after assembling a new elevator, and could no longer reproduce the teleport. Other scenarios have not yet been tested.